Skip to content

Introduce required-checks CI job#1079

Merged
d-e-s-o merged 1 commit intolibbpf:masterfrom
d-e-s-o:topic/required-checks
Jan 22, 2025
Merged

Introduce required-checks CI job#1079
d-e-s-o merged 1 commit intolibbpf:masterfrom
d-e-s-o:topic/required-checks

Conversation

@danielocfb
Copy link
Collaborator

GitHub Actions comes with an auto-merge feature, which allows for automatically merging PRs once certain requirements are met. For us, these requirements would be the passing of all CI checks. Alas, their !@#&()$&@!(# configuration requires us to explicitly list all CI jobs that need to pass, which is an absolute maintenance nightmare. To improve on the situation at least somewhat, introduce a job that captures all required checks, so that the definition of this arbitrary entity is at least co-located with the definition of these jobs and not hidden behind four layers of clicky-bunti UI fluff.

The logic is adapted from:
https://github.com/orgs/community/discussions/75568#discussioncomment-10351973

GitHub Actions comes with an auto-merge feature, which allows for
automatically merging PRs once certain requirements are met. For us,
these requirements would be the passing of all CI checks. Alas, their
!@#*&()$&@!(#* configuration requires us to explicitly list all CI jobs
that need to pass, which is an absolute maintenance nightmare. To
improve on the situation at least somewhat, introduce a job that
captures all required checks, so that the definition of this arbitrary
entity is at least co-located with the definition of these jobs and not
hidden behind four layers of clicky-bunti UI fluff.

The logic is adapted from:
https://github.com/orgs/community/discussions/75568#discussioncomment-10351973

Signed-off-by: Daniel Müller <deso@posteo.net>
@d-e-s-o d-e-s-o force-pushed the topic/required-checks branch 2 times, most recently from a55626a to 7f558fb Compare January 22, 2025 23:57
@d-e-s-o d-e-s-o merged commit c6c7e57 into libbpf:master Jan 22, 2025
13 checks passed
@d-e-s-o d-e-s-o deleted the topic/required-checks branch January 22, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants