examples: Remove bump_memlock_rlimit()#1092
Merged
d-e-s-o merged 3 commits intolibbpf:masterfrom Feb 25, 2025
Merged
Conversation
The bump_memlock_rlimit() is unnecessary since libbpf 1.0. See this [issue](0) and this [commit](1) for details. [0]: libbpf/libbpf#369 [1]: libbpf/libbpf@216eaa7 Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
chenhengqi
force-pushed
the
remove-bump_memlock_rlimit
branch
2 times, most recently
from
f3ac905 to
6a324ca
Compare
The bump_rlimit_mlock() is unnecessary, drop it. Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
chenhengqi
force-pushed
the
remove-bump_memlock_rlimit
branch
from
e9c46d1 to
90f5402
Compare
d-e-s-o
approved these changes
Feb 25, 2025
Collaborator
d-e-s-o
left a comment
d-e-s-o
left a comment
There was a problem hiding this comment.
Ah yes, I was wondering about this functionality, because I also noticed that it no longer seemed necessary. Thanks for getting to the bottom of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bump_memlock_rlimit() is unnecessary since libbpf 1.0. See this issue and this commit for details.