Stop specifying version for vmlinux dependency#1098
Merged
d-e-s-o merged 1 commit intolibbpf:masterfrom Feb 25, 2025
Merged
Conversation
The vmlinux crate isn't really versioned as such, as the only compatibility guarantee provided is that git history won't be clobbered. There is also no intention of publishing it. As such, there is no point in specifying a version -- the SHA1 pinning the git commit is sufficient. Remove any version specifications. Signed-off-by: Daniel Müller <deso@posteo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vmlinux crate isn't really versioned as such, as the only compatibility guarantee provided is that git history won't be clobbered. There is also no intention of publishing it.
As such, there is no point in specifying a version -- the SHA1 pinning the git commit is sufficient. Remove any version specifications.