add: binding for set_autoattach#1106
Merged
danielocfb merged 1 commit intolibbpf:masterfrom Mar 3, 2025
Merged
Conversation
Signed-off-by: yogaraj.s <yogarajsivaprakasam@gmail.com>
chenhengqi
reviewed
Mar 3, 2025
Contributor
chenhengqi
left a comment
chenhengqi
left a comment
There was a problem hiding this comment.
LGTM but the commit message could be improved though.
danielocfb
approved these changes
Mar 3, 2025
Collaborator
There was a problem hiding this comment.
I agree with @chenhengqi, but probably not worth doing another round trip. Please stay consistent with existing commit message styles in the future. Ideally we'd also have a test for this functionality, but given that we don't have one for autoload not going to push for that either. Thanks!
danielocfb
pushed a commit
to d-e-s-o/libbpf-rs
that referenced
this pull request
Mar 3, 2025
Add a CHANGELOG entry for pull request libbpf#1106, which added the OpenProgramMut::set_autoattach() functionality. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
added a commit
that referenced
this pull request
Mar 3, 2025
Add a CHANGELOG entry for pull request #1106, which added the OpenProgramMut::set_autoattach() functionality. Signed-off-by: Daniel Müller <deso@posteo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add binding for
bpf_program__set_autoattachas discussed in #1085 .bpf_program__set_autoattachis of typevoid. So, no return checks are needed.Thanks to @mmullin-halcyon