Simplify stream tests #1292
Merged
Simplify stream tests #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify stream tests by using bpf_stream_printk() as per [0]. We need
to downgrade the kernel here, because commit a00b10df8c89 ("bpf: add
_impl suffix for bpf_stream_vprintk() kfunc") broke everything, as it
leads to a mismatch between the kfunc that any released libbpf emits
versus what the kernel provides. It's great.
[0] libbpf#1284 (comment)
Signed-off-by: Daniel Müller <deso@posteo.net>
danielocfb
force-pushed
the
topic/simple-streams
branch
from
c47ed4c to
31e074b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify stream tests by using bpf_stream_printk() as per [0]. We need to downgrade the kernel here, because commit a00b10df8c89 ("bpf: add _impl suffix for bpf_stream_vprintk() kfunc") broke everything, as it leads to a mismatch between the kfunc that any currently released libbpf emits versus what the kernel provides.
[0] #1284 (comment)