Allow ring__ functions #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jul 31, 2025
Summary: Backports libbpf/libbpf-sys#127 to v1.5.1 (upstream is v1.5.2) Reviewed By: dtolnay Differential Revision: D79299028 fbshipit-source-id: 6a3b7dcc45eb3d838c0d51459fb0fa03aefa600f
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jul 31, 2025
Summary: Backports libbpf/libbpf-sys#127 to v1.5.1 (upstream is v1.5.2) Reviewed By: dtolnay Differential Revision: D79299028 fbshipit-source-id: 6a3b7dcc45eb3d838c0d51459fb0fa03aefa600f
danielocfb
approved these changes
Jul 31, 2025
Collaborator
danielocfb
left a comment
danielocfb
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
Collaborator
|
Do you need a new release with this functionality @calebho ? |
Contributor
Author
|
Nope not urgent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for functions to query ring buffer stats but saw they didn't have Rust bindings
test plan
./rebuild.shis clean