Fix windows static library build parameter in CMakeLists.txt#1182
Merged
COM8 merged 3 commits intolibcpr:masterfrom Feb 17, 2025
Merged
Fix windows static library build parameter in CMakeLists.txt#1182COM8 merged 3 commits intolibcpr:masterfrom
COM8 merged 3 commits intolibcpr:masterfrom
Conversation
COM8
requested changes
Feb 16, 2025
Member
COM8
left a comment
There was a problem hiding this comment.
@MiyamuraMiyako thanks for submitting this PR!
Could you please explain a bit why this is needed? I'm not so deep into msvc stuff.
Also please add a bit of inline comments what your code does and why it is needed.
Contributor
Author
|
@COM8 The current Cmake configuration ( if (MSVC)
if (BUILD_SHARED_LIBS)
message(STATUS "Build windows dynamic libs.")
else()
# Add this to build windows pure static library.
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
message(STATUS "Build windows static libs.")
endif()
endif() |
Member
|
Thanks! From what I can see, you have not yet pushed the comment to your CMake code. You just removed some Compiler definitions. |
Contributor
Author
|
@COM8 Ok, I add this comment to CMakeLists.txt |
COM8
approved these changes
Feb 17, 2025
COM8
added a commit
that referenced
this pull request
Feb 17, 2025
Fix windows static library build parameter in CMakeLists.txt
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cmake parameter
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")to build windows static library.