feat: Use CMAKE_MSVC_RUNTIME_LIBRARY for runtime selection in MSVC(#1…#1199
Merged
COM8 merged 1 commit intolibcpr:masterfrom Mar 20, 2025
Merged
Conversation
…bcpr#1198) Previously, when BUILD_SHARED_LIBS was set to FALSE (OFF), the runtime library was forcibly set to MultiThreaded. This commit replaces that behavior by using the CMAKE_MSVC_RUNTIME_LIBRARY option, allowing users to select between MultiThreaded and MultiThreadedDLL as a build option.
COM8
approved these changes
Mar 20, 2025
Member
COM8
left a comment
COM8
left a comment
There was a problem hiding this comment.
Agree @BestArthur. This should be set by the user. Thanks for creating the MR.
COM8
added a commit
that referenced
this pull request
Mar 20, 2025
feat: Use CMAKE_MSVC_RUNTIME_LIBRARY for runtime selection in MSVC(#1…
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Use CMAKE_MSVC_RUNTIME_LIBRARY for runtime selection in MSVC(#1198)
Previously, when BUILD_SHARED_LIBS was set to FALSE (OFF), the runtime library was
forcibly set to MultiThreaded. This commit replaces that behavior by using the
CMAKE_MSVC_RUNTIME_LIBRARY option, allowing users to select between MultiThreaded
and MultiThreadedDLL as a build option.