Ensure cpr::LowSpeed properties are cased to long for curl#1218
Merged
Conversation
COM8
added a commit
that referenced
this pull request
Jun 14, 2025
Ensure `cpr::LowSpeed` properties are cased to long for curl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the docs,
std::chrono::secondsis at least 36 bit long which would result in 64bit -> long and therefore it implicitly works on 64 bit systems.https://en.cppreference.com/w/cpp/chrono/duration
BUT on 32 bit systems, we need
count()and cast.