Skip to content

fix: make is_same_v check constexpr in set_option_internal #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
COM8 merged 1 commit into from
Sep 20, 2025
Merged

fix: make is_same_v check constexpr in set_option_internal #1248

COM8 merged 1 commit into from
Sep 20, 2025

Conversation

@bi0ha2ard
Copy link
Contributor

@bi0ha2ard bi0ha2ard commented Aug 25, 2025

Adds a missing constexpr to check the result of std::is_same_v<CurrentType, Header>, since its value is known at compiletime.

COM8
COM8 approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@COM8 COM8 merged commit df943a8 into libcpr:master Sep 20, 2025
32 of 36 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@COM8 COM8 COM8 approved these changes

Assignees

No one assigned

Labels

Enhancement 👌

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bi0ha2ard @COM8