Skip to content

Allow disabling PSL #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
COM8 merged 8 commits into from
Sep 28, 2025
Merged

Allow disabling PSL #1253

COM8 merged 8 commits into from
Sep 28, 2025

Conversation

@COM8
Copy link
Member

@COM8 COM8 commented Sep 20, 2025

Adds a new CMake option called CPR_CURL_USE_LIBPSL. It is set to ON by default. It allows toggling PSL support for curl.

Why ON By Default?

  • With 1.12.0 we introduced this on by default behaviour and switching it to off, would introduce a second break here.
  • With PSL support enabled by default, we reflect how curl is behaving by default since cpr aims to only be a C++ wrapper around curl.
  • A secure default by default: The risk of super cookies exists and most people (including me) were/are not aware that something like this is a problem. Providing a secure default therefore is a good thing in my eyes.

This was referenced Sep 20, 2025
Merged
Closed
@COM8 COM8 linked an issue Sep 20, 2025 that may be closed by this pull request
libpsl for curl can actually be optional #1245
Closed
arslan-charyyev
arslan-charyyev suggested changes Sep 20, 2025
View reviewed changes
@COM8 COM8 mentioned this pull request Sep 21, 2025
Open
@COM8 COM8 merged commit 6c605a4 into master Sep 28, 2025
68 of 74 checks passed
@COM8 COM8 deleted the feature/allow_disabling_psl branch September 28, 2025 06:53
grybouilli pushed a commit to grybouilli/cpr that referenced this pull request Oct 24, 2025
@COM8
Allow disabling PSL (libcpr#1253)
b27f048 
* Allow disabling PSL

* Updated build requirements

* Added a CI run to check builds where PSL is disabled

* Enable PSL by default

* Added the missing g++

* Extended the PSL requirements docs

* Use a definitely wrong URL for proxy error tests

* CI: Added missing g++
grybouilli pushed a commit to grybouilli/cpr that referenced this pull request Oct 24, 2025
@COM8
Allow disabling PSL (libcpr#1253)
083856c 
* Allow disabling PSL

* Updated build requirements

* Added a CI run to check builds where PSL is disabled

* Enable PSL by default

* Added the missing g++

* Extended the PSL requirements docs

* Use a definitely wrong URL for proxy error tests

* CI: Added missing g++
@grybouilli grybouilli mentioned this pull request Oct 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arslan-charyyev arslan-charyyev arslan-charyyev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build 👷 Feature ✨

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

libpsl for curl can actually be optional

3 participants

@COM8 @arslan-charyyev