Conversation
xpenatan
reviewed
May 5, 2025
SimonIT
added a commit
to SimonIT/gdx-teavm
that referenced
this pull request
May 10, 2025
Like the gwt backend
xpenatan
added a commit
to xpenatan/gdx-teavm
that referenced
this pull request
May 11, 2025
Make TeaGL20.gl public final for libgdx/gdx-video#109
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a TeaVM-based HTML/JavaScript backend for video playback tests by introducing new launcher and builder classes, integrating a TeaVM-specific module, and wiring up the project settings.
- Added a TeaVM entry point and build tool for test applications
- Introduced a new
gdx-video-teavmmodule containingVideoPlayerTeaand factory - Updated multi-module settings and Gradle properties for TeaVM versions
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/teavm/src/main/java/com/badlogic/gdx/video/test/teavm/TeaVMLauncher.java | HTML/TeaVM application launcher |
| test/teavm/src/main/java/com/badlogic/gdx/video/test/teavm/TeaVMBuilder.java | TeaVM build configuration |
| test/teavm/build.gradle | Build and run tasks for the TeaVM test module |
| settings.gradle | Includes gdx-video-teavm and test:teavm modules |
| gradle.properties | Defines gdxTeaVMVersion and teaVMVersion |
| gdx-video-teavm/src/emu/com/badlogic/gdx/video/VideoPlayerCreator.java | Factory for TeaVM VideoPlayer implementation |
| gdx-video-teavm/src/com/badlogic/gdx/video/VideoPlayerTea.java | Implements VideoPlayer via HTML5 <video> element |
| gdx-video-teavm/res/META-INF/teavm.properties | Maps emu.com package hierarchy for TeaVM |
| gdx-video-teavm/build.gradle | Configures the gdx-video-teavm library module |
Comments suppressed due to low confidence (1)
gdx-video-teavm/src/com/badlogic/gdx/video/VideoPlayerTea.java:33
- [nitpick] Add unit or integration tests for
VideoPlayerTeamethods (e.g.,load,play,update) to validate HTML5 video rendering and event handling under TeaVM.
public class VideoPlayerTea extends AbstractVideoPlayer implements VideoPlayer {
test/teavm/src/main/java/com/badlogic/gdx/video/test/teavm/TeaVMLauncher.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.