Skip to content

Conversation

jorio
Copy link
Contributor

@jorio jorio commented Feb 1, 2025

The existing callback RemoteCallbacks.transfer_progress is only called during fetches, not pushes.
This PR exposes libgit2's push_transfer_progress callback, allowing users to:

  • Report progress during a push;
  • Abort a push by raising an exception in the callback.

Note: I had to rewrite test_push_options to use a real RemoteCallbacks object instead of a mock object (the mock wasn't complete enough to work with my additions to git_push_options)

@jdavid jdavid merged commit 0f54268 into libgit2:master Feb 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants