Skip to content

Conversation

kbaikov
Copy link
Contributor

@kbaikov kbaikov commented Aug 5, 2025

This intoduces a stricter mypy config.

The first step just fixes some unused type ignores.
All according to this doc: https://mypy.readthedocs.io/en/stable/existing_code.html#getting-to-strict
Following the above mentioned doc just becauses i needed some plan of action.

@BenediktSeidl Please take a look.

Comments/suggestions welcome.

@BenediktSeidl
Copy link
Contributor

BenediktSeidl commented Aug 5, 2025

just to make it clear: i have absolutely no authority here, and i'm not sure if my opinion lines up with jdavid.
but i will provide my opinion, when asked for it :-)

  • i would have turned around the commits, so each commit has a chance to be green in the ci, otherwise bisecting does not work.
  • i would explicitly mention warn_unused_ignores in your last commit (then first commit) because that's what you fixed there, right?

otherwise good idea to look in the official docs, maybe i should have done this, before randomly typing files.

kbaikov added 3 commits August 6, 2025 07:39
Don't want to mess with setup.py and types
since they are not that important here.
@kbaikov
Copy link
Contributor Author

kbaikov commented Aug 6, 2025

* i would have turned around the commits, so each commit has a chance to be green in the ci, otherwise bisecting does not work.

done rearranged the commits.
I think some repos just squash all the commits in the PR automaticaly.

Whom can i ping who is the authority here? :) Perhaps @jdavid

@BenediktSeidl Also going forward i noticed a lot of C code and ffi C. I have no idea how to type the python code that calls C. Need help.

@jdavid jdavid merged commit 2a57752 into libgit2:master Aug 6, 2025
8 checks passed
@kbaikov kbaikov deleted the mypy-fixes branch August 6, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants