Skip to content

Conversation

@guyingzhao
Copy link
Contributor

  1. change delete to free since plist_get_string_val allocate memory with malloc
  2. support assigning String by const char* to avoid memory duplication

@nikias
Copy link
Member

nikias commented Mar 2, 2025

There are conflicts. Could you please try to not change the coding style/indentation? That makes it easier for me. I already redid your earlier two commits so we just have the changes. Thanks.

@guyingzhao guyingzhao force-pushed the master branch 6 times, most recently from bcb81fd to c7a5fab Compare March 2, 2025 17:53
@guyingzhao
Copy link
Contributor Author

guyingzhao commented Mar 2, 2025

@nikias I have resolved the conflicts and submitted the code again, but it seems that the branch have some issues on CI checks. I don't think the errors come from my code and it works fine locally. Please let me know if I need to fix my code, thanks.

Well, I dived into the error logs and fixed them, the branch is clean to be merged. Please have a look at this pull request @nikias

@guyingzhao
Copy link
Contributor Author

@nikias , could you please review the request so I can go back to original libplist repo.

@nikias
Copy link
Member

nikias commented Apr 6, 2025

@guyingzhao ok I think I addressed almost all of your changes now.

@guyingzhao guyingzhao closed this Apr 9, 2025
@guyingzhao
Copy link
Contributor Author

@guyingzhao ok I think I addressed almost all of your changes now.

Thanks a lot, I'll create another request to fix the assert error under debug mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants