Skip to content

Conversation

@turuslan
Copy link
Contributor

  • read was called twice, from onMessageRead and onMessageWritten
  • simplify and deduplicate read/write request/response
    • server (SessionHost) reads request, writes response, repeats.
    • client (ResponseHandler) writes request, reads response, closes stream.
      • ADD_PROVIDER writes request, (no response), closes stream.
  • read uses MessageReadWriterUvarint, but write doesn't use that because Message::serialize adds length prefix.

@turuslan turuslan requested a review from igor-egorov November 29, 2024 05:41
@turuslan turuslan mentioned this pull request Nov 29, 2024
@turuslan turuslan merged commit a52146d into master Nov 29, 2024
4 checks passed
@turuslan turuslan deleted the fix/kad-session branch November 29, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants