buffered provider #1149
Merged
buffered provider #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
reviewed
Sep 16, 2025
guillaumemichel
force-pushed
the
buffered-provider
branch
from
edc0d36 to
450daee
Compare
This was referenced Sep 16, 2025
Closed
guillaumemichel
added a commit
to guillaumemichel/go-libp2p-kad-dht
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code * buffered provider * tests * removing redundant code * docs * wait on empty queue * fix flaky test
guillaumemichel
added a commit
to guillaumemichel/go-libp2p-kad-dht
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code * buffered provider * tests * removing redundant code * docs * wait on empty queue * fix flaky test
guillaumemichel
added a commit
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code * buffered provider * tests * removing redundant code * docs * wait on empty queue * fix flaky test
guillaumemichel
added a commit
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code * buffered provider * tests * removing redundant code * docs * wait on empty queue * fix flaky test
guillaumemichel
added a commit
that referenced
this pull request
Sep 18, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code * buffered provider * tests * removing redundant code * docs * wait on empty queue * fix flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1145
Part of #1095
Supersedes #1148
Summary
Introduces a wrapper around the
SweepingProviderqueuing operations and processing them by batches.This allows users (such as Kubo) of this new
buffered.SweepingProviderto have a fully async (and fast!)SweepingProvider.The queue implementation is go-dsqueue.
This solution keeps queuing complexity out of the
SweepingProviderimplementation, and makes the queue optional.Since this is a wrapper, it can wrap either
provider.SweepingProviderordual.SweepingProvider(dual DHT provider).Alternatives
#1148 (draft) also implements queuing but has the following drawbacks:
provider.SweepingProviderinternal need to be exposed for the dual DHT providerMinor changes
dual/providertoprovider/dualso that it can accessprovider/internal.