make IPv6 subnet colocation optional as a peer score parameter#387
Open
make IPv6 subnet colocation optional as a peer score parameter#387
Conversation
vyzo
changed the title
Member
|
What's the rationale? was this being abused? |
Collaborator
Author
|
no, but it can create problems with providers like textile. |
Collaborator
Author
|
basically I want to make it an option, it's something we discussed with the eth2 folks as well. |
raulk
reviewed
Sep 14, 2020
Member
raulk
left a comment
raulk
left a comment
There was a problem hiding this comment.
Mind editing the PR body and explaining the observations from Eth2 and Filecoin that justify making this change? The patch is easy to understand, but the desired impact isn't, and that makes it obscure for the community to follow the direction. Thanks!
|
cc @jleni this might be of interest too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.