Open
Conversation
Replace real libp2p hosts with simulated in-memory network (simlibp2p) and wrap all ~200 tests in Go 1.25's synctest.Test for deterministic time. This eliminates flakiness and speeds up the test suite. Production code change: make GossipSub heartbeatTimer respect context cancellation during initial delay. Tests migrated by Claude Opus 4.6
MarcoPolo
force-pushed
the
migrate-simlibp2p
branch
from
2fab116 to
c82f0f6
Compare
Contributor
|
WoW, recently it took 17m on the CI, i guess it should take a fraction of the time now . Amazing 🤩. @MarcoPolo Since the |
sukunrt
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highly recommend ignoring whitespace changes.
?w=1parameter in the github UI.This removes flakiness from the tests, and makes the tests run much much faster. On my machine tests now finish in 30s (previously took: 380s; 10x faster)
Replace real libp2p hosts with simulated in-memory network (simlibp2p) and wrap all ~200 tests in Go 1.25's synctest.Test for deterministic time. This eliminates flakiness and speeds up the test suite.
Production code change: make GossipSub heartbeatTimer respect context cancellation during initial delay.
Tests migrated by Claude Opus 4.6