Skip to content

Add support for network interfaces in mDNS configuration #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add support for network interfaces in mDNS configuration #3159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcbe16d
Add support for network interfaces in mDNS configuration
cpeliciari Jan 27, 2025
bc9686c
Add anet
cpeliciari Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ require (
github.com/quic-go/webtransport-go v0.8.1-0.20241018022711-4ac2c9250e66
github.com/raulk/go-watchdog v1.3.0
github.com/stretchr/testify v1.10.0
github.com/wlynxg/anet v0.0.5
go.uber.org/fx v1.23.0
go.uber.org/goleak v1.3.0
go.uber.org/mock v0.5.0
Expand Down Expand Up @@ -127,7 +128,6 @@ require (
github.com/quic-go/qpack v0.5.1 // indirect
github.com/spaolacci/murmur3 v1.1.0 // indirect
github.com/syndtr/goleveldb v1.0.0 // indirect
github.com/wlynxg/anet v0.0.5 // indirect
go.uber.org/dig v1.18.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
golang.org/x/mod v0.22.0 // indirect
Expand Down
8 changes: 7 additions & 1 deletion p2p/discovery/mdns/mdns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package mdns
import (
"context"
"errors"
"github.com/wlynxg/anet"
"io"
"math/rand"
"strings"
Expand Down Expand Up @@ -133,6 +134,11 @@ func (s *mdnsService) startServer() error {
return err
}

ifaces, err := anet.Interfaces()
if err != nil {
return err
}

server, err := zeroconf.RegisterProxy(
s.peerName,
s.serviceName,
Expand All @@ -141,7 +147,7 @@ func (s *mdnsService) startServer() error {
s.peerName,
ips,
txts,
nil,
ifaces,
)
if err != nil {
return err
Expand Down
Loading