Skip to content

Conversation

@sukunrt
Copy link
Member

@sukunrt sukunrt commented Mar 21, 2025

No description provided.

@sukunrt sukunrt changed the title Release 0.41.1 Do-NOT-MERGE Release 0.41.1 Mar 21, 2025
@sukunrt sukunrt marked this pull request as draft March 21, 2025 18:19
@sukunrt
Copy link
Member Author

sukunrt commented Mar 24, 2025

@MarcoPolo

Can we include #3225 in the release?
It introduces a new public constant:
var DefaultNewStreamTimeout = 10 * time.Second in a patch release?

@sukunrt sukunrt changed the title Do-NOT-MERGE Release 0.41.1 Release 0.41.1 Mar 24, 2025
@sukunrt sukunrt requested a review from MarcoPolo March 24, 2025 17:03
@sukunrt sukunrt marked this pull request as ready for review March 24, 2025 17:03
@MarcoPolo
Copy link
Collaborator

We can unexport it for the patch, and then re-export it for the next release

algorandskiy and others added 5 commits March 24, 2025 22:45
This context wasn't being cancelled on all code paths. In particular,
contexts for connections that didn't complete negotiation were not being
cancelled.

The change arranges for either `udpmux.muxedConnection.Close` or 
`RemoveConnByUfrag` to call the other.

Fixes: #3223
reuse port didn't work for the second transport, either QUIC or 
WebTransport, that was used for listening. This change fixes 
it by calling associate on all paths. 

This impacted hole punching for some users since you cannot hole 
punch without reuse port. There's a test in holepunch package
to prevent regressions. 

Fixes #3165

Co-authored-by: Marco Munizaga <[email protected]>
@github-actions
Copy link

Cutting a Release (when not on ["master"])

This PR is targeting release-v041, which is not any of ["master"].
If you wish to cut a release once this PR is merged, please add the release label to this PR.

@sukunrt
Copy link
Member Author

sukunrt commented Mar 24, 2025

Unexported that variable in this commit: 1b3b1ed

@sukunrt sukunrt merged commit 8ce45df into release-v041 Mar 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants