Skip to content

Conversation

@sukunrt
Copy link
Member

@sukunrt sukunrt commented Aug 1, 2025

Cutting a release so that users can upgrade quic-go.

Kubo PR: ipfs/kubo#10892

@sukunrt sukunrt added the release label Aug 1, 2025
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Suggested version: 0.43.0

Comparing to: v0.43.0-alpha-1 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# github.com/libp2p/go-libp2p/p2p/transport/quic
## errors in release version:
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/conn.go:16:17: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/transport.go:53:18: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/listener.go:86:40: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/listener.go:115:49: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/transport.go:177:39: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/transport.go:183:42: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/transport.go:347:51: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quic/transport.go:98:31: undefined: quic.Connection

# github.com/libp2p/go-libp2p/p2p/transport/quicreuse
## errors in release version:
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/connmgr.go:27:36: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/connmgr.go:36:89: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/reuse.go:28:89: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:160:30: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:29:37: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:20:32: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/connmgr.go:201:109: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/connmgr.go:211:138: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/connmgr.go:335:129: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/connmgr.go:335:167: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:83:54: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:94:84: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:188:54: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:180:31: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/reuse.go:48:119: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/listener.go:172:37: undefined: quic.Connection

## incompatible changes
(*ConnManager).DialQUIC: changed from func(context.Context, github.com/multiformats/go-multiaddr.Multiaddr, *crypto/tls.Config, func(conn *github.com/quic-go/quic-go.Conn, delta uint64) bool) (*github.com/quic-go/quic-go.Conn, error) to func(context.Context, github.com/multiformats/go-multiaddr.Multiaddr, *crypto/tls.Config, func(conn invalid type, delta uint64) bool) (invalid type, error)
(*ConnManager).ListenQUIC: changed from func(github.com/multiformats/go-multiaddr.Multiaddr, *crypto/tls.Config, func(conn *github.com/quic-go/quic-go.Conn, delta uint64) bool) (Listener, error) to func(github.com/multiformats/go-multiaddr.Multiaddr, *crypto/tls.Config, func(conn invalid type, delta uint64) bool) (Listener, error)
(*ConnManager).ListenQUICAndAssociate: changed from func(any, github.com/multiformats/go-multiaddr.Multiaddr, *crypto/tls.Config, func(conn *github.com/quic-go/quic-go.Conn, delta uint64) bool) (Listener, error) to func(any, github.com/multiformats/go-multiaddr.Multiaddr, *crypto/tls.Config, func(conn invalid type, delta uint64) bool) (Listener, error)
Listener.Accept: changed from func(context.Context) (*github.com/quic-go/quic-go.Conn, error) to func(context.Context) (invalid type, error)
QUICListener.Accept: changed from func(context.Context) (*github.com/quic-go/quic-go.Conn, error) to func(context.Context) (invalid type, error)
QUICTransport.Dial: changed from func(context.Context, net.Addr, *crypto/tls.Config, *github.com/quic-go/quic-go.Config) (*github.com/quic-go/quic-go.Conn, error) to func(context.Context, net.Addr, *crypto/tls.Config, *github.com/quic-go/quic-go.Config) (invalid type, error)
RefCountedQUICTransport.Dial: changed from func(context.Context, net.Addr, *crypto/tls.Config, *github.com/quic-go/quic-go.Config) (*github.com/quic-go/quic-go.Conn, error) to func(context.Context, net.Addr, *crypto/tls.Config, *github.com/quic-go/quic-go.Config) (invalid type, error)

# github.com/libp2p/go-libp2p/p2p/transport/webtransport
## errors in release version:
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:89:28: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/conn.go:35:13: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/listener.go:32:7: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/conn.go:40:134: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/listener.go:42:42: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/listener.go:57:43: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:191:153: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:360:51: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:371:39: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:377:42: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/conn.go:63:17: cannot use str (variable of type *webtransport.Stream) as webtransport.Stream value in struct literal
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/conn.go:55:17: cannot use str (variable of type *webtransport.Stream) as webtransport.Stream value in struct literal
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/listener.go:109:51: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/listener.go:129:31: cannot use wrapped (variable of type *negotiatingConn) as *quic.Conn value in argument to ln.server.ServeQUICConn
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/listener.go:271:61: cannot use str (variable of type *webtransport.Stream) as webtransport.Stream value in struct literal
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:116:30: undefined: quic.Connection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:218:84: undefined: quic.EarlyConnection
/home/runner/go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/webtransport/transport.go:277:62: cannot use str (variable of type *webtransport.Stream) as webtransport.Stream value in struct literal

# diagnostics
go.mod: the following requirements are needed
	github.com/cheekybits/[email protected]
	github.com/containerd/[email protected]
	github.com/coreos/go-systemd/[email protected]
	github.com/docker/[email protected]
	github.com/elastic/[email protected]
	github.com/fsnotify/[email protected]
	github.com/go-task/[email protected]
	github.com/godbus/dbus/[email protected]
	github.com/gogo/[email protected]
	github.com/golang/[email protected]
	github.com/hashicorp/[email protected]
	github.com/libp2p/[email protected]
	github.com/libp2p/[email protected]
	github.com/libp2p/go-yamux/[email protected]
	github.com/lucas-clemente/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/mattn/[email protected]
	github.com/nxadm/[email protected]
	github.com/onsi/[email protected]
	github.com/opencontainers/[email protected]
	github.com/pkg/[email protected]
	github.com/raulk/[email protected]
	github.com/spacemonkeygo/[email protected]
	[email protected]
	gopkg.in/[email protected]
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Cannot suggest a release version.
Errors were found.

gocompat says:

HEAD is now at 07e9ebdd Release v0.43
Previous HEAD position was 07e9ebdd Release v0.43
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@sukunrt sukunrt requested a review from MarcoPolo August 2, 2025 08:00
@sukunrt sukunrt merged commit b75e678 into master Aug 7, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants