refactor: replace context.WithCancel with t.Context#3383
Merged
MarcoPolo merged 1 commit intolibp2p:masterfrom Sep 18, 2025
Merged
refactor: replace context.WithCancel with t.Context#3383MarcoPolo merged 1 commit intolibp2p:masterfrom
MarcoPolo merged 1 commit intolibp2p:masterfrom
Conversation
MarcoPolo
approved these changes
Sep 17, 2025
MarcoPolo
requested changes
Sep 17, 2025
Collaborator
MarcoPolo
left a comment
MarcoPolo
left a comment
There was a problem hiding this comment.
Error: p2p/net/gostream/gostream_test.go:5:2: "context" imported and not used
You probably need to gofmt these files
Signed-off-by: cargoedit <cargoedit@outlook.com>
Contributor
Author
Oh. Indeed. Modified. @MarcoPolo Please review again when youn have time. Thanks! |
MarcoPolo
approved these changes
Sep 18, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize code using a more concise and modern approach.