Skip to content

fix(peer): skip nil addresses in AddrInfo.MarshalJSON #3442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidel wants to merge 2 commits into from
+12 −3
Closed

fix(peer): skip nil addresses in AddrInfo.MarshalJSON #3442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080845e
fix(peer): skip nil addresses in AddrInfo.MarshalJSON
lidel Dec 20, 2025
f2979bd
fix(peer): log warning when nil multiaddr is skipped
lidel Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions core/peer/addrinfo_serde.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package peer

import (
"encoding/json"
"fmt"
"os"

"github.com/libp2p/go-libp2p/core/internal/catch"

Expand All @@ -17,9 +19,16 @@ type addrInfoJson struct {
func (pi AddrInfo) MarshalJSON() (res []byte, err error) {
defer func() { catch.HandlePanic(recover(), &err, "libp2p addr info marshal") }()

addrs := make([]string, len(pi.Addrs))
for i, addr := range pi.Addrs {
addrs[i] = addr.String()
// Skip nil addresses to avoid panic if slice contains corrupted entries
// (likely due to data race). Log warning for visibility.
// See: https://github.com/ipfs/kubo/issues/11116
addrs := make([]string, 0, len(pi.Addrs))
for _, addr := range pi.Addrs {
if addr == nil {
fmt.Fprintf(os.Stderr, "go-libp2p: nil multiaddr in AddrInfo.MarshalJSON for peer %s (possible data race)\n", pi.ID)
continue
}
addrs = append(addrs, addr.String())
}
return json.Marshal(&addrInfoJson{
ID: pi.ID,
Expand Down
Loading