bump pion/dtls to v3.1.2 (AES-GCM nonce fix) + migrate to github.com/pion/stun/v3 and eliminate legacy Pion v2#3465
Closed
dindinw wants to merge 0 commit intolibp2p:masterfrom
Closed
bump pion/dtls to v3.1.2 (AES-GCM nonce fix) + migrate to github.com/pion/stun/v3 and eliminate legacy Pion v2#3465dindinw wants to merge 0 commit intolibp2p:masterfrom
dindinw wants to merge 0 commit intolibp2p:masterfrom
Conversation
Member
|
I made an incorrect push and now I can't push to your fork. I'll make a new PR with you as the coauthor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the WebRTC UDP mux from the legacy STUN module (
github.com/pion/stun v0.6.1) to eliminate the legacygithub.com/pion/dtls/v2andgithub.com/pion/transport/v2There is a separate DTLS vulnerability (CVE-2026-26014 / GHSA-9f3f-wv7r-qc8r) where Pion DTLS versions v1.0.0 through v3.0.10 (and 3.1.0) used random nonces with AES-GCM, risking nonce reuse and making it easier to recover the authentication key (“forbidden attack”). we can only remove the older v2 line and use the latest v3 line to fix the issue.