fix: get the daemon working outside of tests#127
Open
saul-jb wants to merge 42 commits intolibp2p:mainfrom
Open
fix: get the daemon working outside of tests#127saul-jb wants to merge 42 commits intolibp2p:mainfrom
saul-jb wants to merge 42 commits intolibp2p:mainfrom
Conversation
added 21 commits
September 9, 2022 15:03
Author
|
This now works with UNIX domain sockets! |
mpetrunic
reviewed
Oct 28, 2022
added 8 commits
November 2, 2022 11:37
Author
|
A couple of notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have had a go at fixing the problems with running the daemon outside the
libp2pinterop suite as discussed in issue #83.libp2p-daemon-clientstream.spec.tstest becauseit-handshakereturns aUint8ArrayListnot aUint8Arrayit-handshaketypes that was making the compile fail.libp2p-daemontests have been enabled and updated.psk,pubsubDiscovery,discoveryIntervaland relay specific cli arguments.