docs: add auto-tls example #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
docs/add-auto-tls-example
branch
from
fcdbcb1 to
c06104f
Compare
Adds an example showing how to configure auto-tls and includes discussion of some of the trade-offs and descisions you have to make.
achingbrain
force-pushed
the
docs/add-auto-tls-example
branch
from
c06104f to
230e8a5
Compare
2color
reviewed
Dec 17, 2024
| // other config | ||
| tcp() | ||
| ], | ||
| services: { |
There was a problem hiding this comment.
How did you decide which services to keep for each of these sections?
For example, shouldn't we also include identify here which is necessary for most of the other services to work?
Member
Author
There was a problem hiding this comment.
It was meant to be an additive thing, not replacing the existing config blocks.
It says // other config everywhere but I guess that's not obvious enough - do you think using a formatted diff instead of a js code block would be clearer?
There was a problem hiding this comment.
Yeah I think adding a diff block would be better, runnable code is included, so should be a problem
|
Nice! |
achingbrain
added a commit
that referenced
this pull request
Dec 20, 2024
Follow up to address issues raised in #194 (comment) Use diff blocks to show code changes over time to make it easier to follow.
3 tasks
achingbrain
added a commit
that referenced
this pull request
Jan 6, 2025
Follow up to address issues raised in #194 (comment) Use diff blocks to show code changes over time to make it easier to follow.
github-actions bot
pushed a commit
to libp2p/js-libp2p-example-auto-tls
that referenced
this pull request
Jan 6, 2025
Follow up to address issues raised in libp2p/js-libp2p-examples#194 (comment) Use diff blocks to show code changes over time to make it easier to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example showing how to configure auto-tls and includes discussion of some of the trade-offs and descisions you have to make.
Change checklist