fix: remove slow network test #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reliable way to test this in a transport agnostic way. The idea is if async work is done after `.dial` is invoked but before `upgrader.upgradeInbound` is called, and the abort signal aborts, then `.dial` should respect the abort and throw, but there's no cross-transport way to inject the latency that would cause the test to fail so remove the test.
maschad
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is if async work is done after
.dialis invoked but beforeupgrader.upgradeInboundis called, and the abort signal aborts, then.dialshould respect the abort and throw, but there's no reliable cross-transport way to inject the latency that would cause the test to fail so remove the test.Change checklist