Skip to content

fix: only log when data is invalid #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
achingbrain merged 1 commit into from
Nov 29, 2024
Merged

fix: only log when data is invalid #2862

achingbrain merged 1 commit into from
Nov 29, 2024

Conversation

@achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 29, 2024

Only log an error when parsing peer data fails, not when it is not present.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: only log when data is invalid
894479d 
Only log an error when parsing peer data fails, not when it is not
present.
@achingbrain achingbrain requested a review from a team as a code owner November 29, 2024 17:46
@achingbrain achingbrain merged commit a0c8ceb into main Nov 29, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/quieter-logs branch November 29, 2024 18:11
@achingbrain achingbrain mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achingbrain