fix: avoid wasteful reprovides outside threshold #3238
+169
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a couple of DHT bugs related to how provider records are handled and processed:
packages/kad-dht/src/reprovider.ts
that causes wasteful reproviding of records that long before reaching the threshold. This would cause valid records to be provided everyREPROVIDE_INTERVAL
Other small changes:
cleanUp
(which is misleading given that it triggers the reprovides) to a more descriptive nameprocessRecords
Notes & open questions
Change checklist