-
Notifications
You must be signed in to change notification settings - Fork 492
fix: avoid wasteful reprovides outside threshold #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition `(now - expires) < this.reprovideThreshold` will be true for **all non-expired records**, regardless of how far from expiration they are
The old MAX_RECORD_AGE seems to be from before the increase of record validity to 48 hours, and is in essence an outdated duplicate. This fix ensures that provider records are returned in RPC requests as long as they are within the 48 hour PROVIDERS_VALIDITY
achingbrain
reviewed
Aug 14, 2025
achingbrain
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a couple of DHT bugs related to how provider records are handled and processed:
packages/kad-dht/src/reprovider.ts
that causes wasteful reproviding of records that long before reaching the threshold. This would cause valid records to be provided everyREPROVIDE_INTERVAL
PROVIDERS_VALIDITY
instead ofMAX_RECORD_AGE
(36 hours) which seems to be from before the increase of DHT record validity to 48 hours, and is in essence an outdated duplicate. This fix ensures that provider records are returned in RPC requests as long as they are within the 48 hour PROVIDERS_VALIDITY.Other small changes:
cleanUp
(which is misleading given that it triggers the reprovides) to a more descriptive nameprocessRecords
Notes & open questions
Change checklist