-
Notifications
You must be signed in to change notification settings - Fork 204
feat: multibase integration #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@asmit27rai : Thanks for the detailed breakdown and the solid work on the multibase integration — the phased approach and backward compatibility are especially well thought out 👏 Inviting @lla-dane, @yashksaini-coder, @sumanjeet0012, @acul71 to review the changes, particularly around the internal migration, API defaults, and config surface. Noting that a few CI/CD checks are currently failing (docs, lint across multiple Python versions, and Windows 3.13 core). Could you please take a pass at fixing these so we can get this into a mergeable state? Happy to help debug if needed. Overall, this is a strong contribution and a meaningful step forward for py-libp2p. Looking forward to the reviews and CI being green ✅ |
Multibase Integration (PR #1179)Issues that I FoundCritical Blockers
Major Issues
Security Risks & Risk Mitigations
|
Multibase Integration
Integration of py-multibase into py-libp2p as discussed here #1173.
Phase-wise Plan
Phase 1: Add Multibase Support (Completed)
py-multibaseas a dependency.Phase 2: Internal Migration (Completed)
Phase 3: External API & Config (Completed)
Testing