fix(gossipsub): queue early publishes until identify completes #1201
+523
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imApoorva36
force-pushed
the
fix/gossipsub-identify-aware-publish
branch
from
e21772b to
69c5cbf
Compare
Contributor
Author
|
@seetadev @sumanjeet0012 this PR is now ready for review, would love your thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GossipSub could drop messages published immediately after connecting to a
peer, before the identify handshake completed. While #893 prevented a
crash, the behavior was still timing-dependent.
This PR makes publishing identify-aware by queueing messages for peers
whose protocol negotiation is still in progress and flushing them once
the peer stream is registered.
Includes regression tests for early publish scenarios.
Closes #887