WIP: Interop for ping on py-libp2p and rust-libp2p #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/paschal533/py-libp2p into feature/replace-mplex-with-yamux
… with a comment explaining its structure
Fixed est_net_stream_read_after_remote_closed by updating NetStream.read to raise StreamEOF when the stream is remotely closed and no data is available, aligning with test expectations and Fixed est_net_stream_read_until_eof by modifying YamuxStream.read to block until the stream is closed ( ecv_closed=True) for =-1 reads, ensuring data is only returned after remote closure.
Fixed est_net_stream_read_after_remote_closed by updating NetStream.read to raise StreamEOF when the stream is remotely closed and no data is available, aligning with test expectations and Fixed est_net_stream_read_until_eof by modifying YamuxStream.read to block until the stream is closed ( ecv_closed=True) for =-1 reads, ensuring data is only returned after remote closure.
…/paschal533/py-libp2p into feature/replace-mplex-with-yamux
…/paschal533/py-libp2p into feature/replace-mplex-with-yamux
…/paschal533/py-libp2p into feature/replace-mplex-with-yamux
|
@lla-dane : Thank you for sharing the PR. @acul71 and @paschal533 should land yamux PR this week. Could you please merge the yamux changes locally and try interop tests with rust-libp2p? |
removed unused ```python import os import logging ```
Feature/replace mplex with yamux
…/paschal533/py-libp2p into feature/replace-mplex-with-yamux
refactor: remove debug logging and improve x25519 tests
|
Migrated the relevant commits in #620 . Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a work-progress pull request for establishing interoperability between
py-libp2pandrust-libp2p.Changes
The directory structure is similar to
./interop-testsinrust-libp2p.interop/exec/native_ping.pyinterop/exec/config: env variables for ping testinterop/arch.py:RedisClientandSwarmBuilderutilitiesinterop/lib.py:handle_ping,send_pingandrun_test(SwarmRunner) utilitiesCurrent Status
Ping test is successful for 2
py-libp2pnodes withinsecure, secioandmplex.Logs
Listener
Dialer
Next Steps
Extend the support for
NoiseandYamux, to test interoperability withrust-libp2p.@seetadev @paschal533