-
Notifications
You must be signed in to change notification settings - Fork 173
FIXME: Make TProtocol Optional[TProtocol] to keep types consistent #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please take a look at this @seetadev , If you tell me some pointers on how to check its reliability, that would be really helpful. Currently I just change the TProtocol as Optional[TProtocol] and totally rely on tests ("tests/core/protocol_muxer/test_protocol_muxer.py", pre-commit tests) to make further changes. |
@Jineshbansal : Great, thank you so much for sharing the PR. Appreciate it. Definitely, I'll review it. CCing @sumanjeet0012 and @acul71 for their feedback and review too. |
I've seen that windows test failing randomly in other PRs |
@acul71 thanks for pointing it out, I will definitely look into this |
@acul71 , @Jineshbansal : Not related, we can ignore this test case. CCing @mystical-prog, who could help fix it via a PR. @Jineshbansal : Please add newsfragment and more test cases. |
@Jineshbansal @seetadev |
@acul71 , sorry I couldn't get a time for this, I will finalize my changes in this week |
What was wrong?
This PR aims to make TProtocol as Optional[TProtocol] to keep types consistent in py-libp2p/libp2p/protocol_muxer/multiselect.py