Skip to content

Fix type annotation inconsistency in negotiate() method #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix type annotation inconsistency in negotiate() method #787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c8ffe
Fix type annotation inconsistency in negotiate() method
keval215 Jul 23, 2025
ab22090
Merge branch 'main' into feature/add-temporary-files
seetadev Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,6 @@ env.bak/
#lockfiles
uv.lock
poetry.lock

# Temporary upload files
.tmp.driveupload/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny I was using directory downloads/ for that
line

py-libp2p/.gitignore

Line 29 in c8c8ffe

downloads/

3 changes: 1 addition & 2 deletions libp2p/protocol_muxer/multiselect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,11 @@ def add_handler(
"""
self.handlers[protocol] = handler

# FIXME: Make TProtocol Optional[TProtocol] to keep types consistent
async def negotiate(
self,
communicator: IMultiselectCommunicator,
negotiate_timeout: int = DEFAULT_NEGOTIATE_TIMEOUT,
) -> tuple[TProtocol, StreamHandlerFn | None]:
) -> tuple[TProtocol | None, StreamHandlerFn | None]:
"""
Negotiate performs protocol selection.

Expand Down
Loading