fix(yamux): add concurrency lock to YamuxStream to prevent data corruption #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a critical enhancement to the concurrency model of the Yamux stream muxer in
py-libp2p
. The update addresses a race condition where concurrent read and write operations on the sameYamuxStream
instance could interleave, resulting in data corruption and unpredictable protocol behavior.Summary of Changes
self.rw_lock
) to theYamuxStream
class.read
andwrite
methods are now protected by this lock, ensuring that only one coroutine can access these methods at a time for a given stream.Impact