fix: Added multiselect type consistency in negotiate method
#814
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to handle none
unniznd
changed the title
negotiate methodnegotiate method
|
Looks good, @unniznd. Please add a newsfragment and it should be good to go. |
|
@pacrob Added the newsfragment. |
Signed-off-by: varun-r-mallya <[email protected]>
Signed-off-by: varun-r-mallya <[email protected]>
Signed-off-by: varun-r-mallya <[email protected]>
This reverts commit 400ee9b.
This reverts commit 2730db4.
|
I will create a new PR. Small mistake, I did rebase. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The multiselect type was inconsistent
How was it fixed?
Set the return type to None and handled the places where the
negotiatefunction is used.Summary of approach.
To-Do
Cute Animal Picture