-
Notifications
You must be signed in to change notification settings - Fork 178
TLS documentation for Issue #700 #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
checking consistency... /home/docs/checkouts/readthedocs.org/user_builds/py-libp2p/checkouts/844/docs/tls-support.rst: WARNING: document isn't included in any toctree you need to add the new |
@acul71 |
@Fatumayattani , @acul71 : Thank you so much for the effort on TLS documentation. Please resolve the CI/CD issues. CCing @guha-rahul , who is actively working on introducing TLS and AutoTLS module in py-libp2p. |
@Fatumayattani Git Diff Outputdiff --git a/docs/tls-support.rst b/docs/tls-support.rst
index 3d9de53..aee3f00 100644
--- a/docs/tls-support.rst
+++ b/docs/tls-support.rst
@@ -1,4 +1,4 @@
-Py-libp2p – TLS Support Documentation
+Py-libp2p – TLS Support Documentation
======================================================
.. contents::
@@ -159,7 +159,3 @@ Troubleshooting
* - Connection refused
- Port blocked or listener not running
- Check firewall rules and listener status.
-
-
-
- ExplanationThe diff shows minor formatting changes to
|
docs/tls-support.rst
Outdated
|
||
.. code-block:: python | ||
|
||
import asyncio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fatumayattani
Even if's ok, usually we use Trio
instead of asyncio
consider using it, you can see examples in /examples directory
Enabling TLS in py-libp2p | ||
------------------------- | ||
|
||
**Working example – Listener and Dialer** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional:
If you want you can add the example in the examples/
directory https://github.com/libp2p/py-libp2p/tree/main/examples
and include that in tls-support.rst
see https://github.com/libp2p/py-libp2p/blob/main/docs/examples.identify.rst
@seetadev Thanks for pointing that out 🙏 I’ll run make pr to address linting and type checks, and push the updated commit. Appreciate the guidance on keeping docs consistent. |
@Fatumayattani : The correct PR is #831. |
@guha-rahul is maintaining the PR. The older PR had to be closed in favor of #831. |
What was wrong?
Issue #700 – Missing documentation on enabling, configuring, and testing TLS in py-libp2p.
How was it fixed?
Added a new TLS documentation file under
docs/tls-support.rst
that covers:To-Do