Tracking: Transport, Relay, and Discovery Enhancements by codemaestro64 · Pull Request #996 · libp2p/py-libp2p

codemaestro64 · 2025-10-16T12:42:18Z

What was wrong?

Issue #691

The libp2p stack lacked robust relay support, secure resource validation, and dynamic peer discovery, impacting reliability in NATed or firewalled environments.

Description

This PR enhances the py-libp2p networking layer with improvements to relay functionality and security, advancing the library toward production-grade reliability for decentralized applications.

TODOs

Implement voucher and signature verification in resources.py
Implement initial relay selection logic in transport.py
Implement DHT-based peer discovery
Implement more sophisticated relay selection
Implement reservation storage and refresh mechanism
Add relay multiaddrs to peerstore
Implement proper multiaddr parsing and handling for relayed connections
Implement run() method in CircuitV2Listener

closes #691

seetadev · 2025-10-20T18:40:57Z

@codemaestro64 : Thank you so much for opening the PR for completing all the required enhancements and todos in circuit relay. Appreciate your efforts.

Updated the branch and re-run CI/CD pipeline. You will get immediate results on CI/CD test cases.

seetadev · 2025-10-27T08:13:12Z

@codemaestro64 : Appreciate your efforts.

Wish to invite @acul71 , @lla-dane, @Winter-Soren for sharing feedback points on the PR.

Winter-Soren · 2025-10-30T18:35:59Z

Hey @codemaestro64,
I have reviewed your PR.
delivers production‑grade rigor: secure reservation validation, resilient relay discovery/selection, durable reservation management, and correct circuit multiaddr behavior. The protocol/service lifecycle is implemented cleanly with timeouts and explicit error signaling. Tests cover the core and many edge conditions. This is a well‑structured, merge‑ready upgrade that improves reliability and parity with other libp2p stacks.

CC'ing @seetadev @acul71

pacrob · 2025-11-02T20:28:58Z

libp2p/relay/circuit_v2/transport.py

+        # Prefer stored /p2p-circuit addrs from peerstore
+        # Try first to read addresses from peerstore
+        peer_store = self.host.get_peerstore()
+        stored_addrs = peer_store.addrs(peer_info.peer_id)


peer_store.addrs will raise a PeerStoreError if the peer we're dialing isn't already in the peerstore, making dialing new peers impossible. Maybe wrap in a try/except or similar?

add pymock to test depenencies

…nnects and discovery

fix signed_envelope error fix tests fix lint issue

seetadev · 2025-11-11T21:16:10Z

@codemaestro64 : Great work. Appreciate the progress.

Please reply to @pacrob so that he can review and mark the feedback as resolved.

There is one CI/CD failure, which can be ignored for now (not related to the PR):

=========================== short test summary info ============================
FAILED tests/core/kad_dht/test_kad_dht.py::test_put_and_get_value - Assertion...
============ 1 failed, 1551 passed, 5 warnings in 553.16s (0:09:13) ============
py311-core: exit 1 (554.53 seconds) /home/runner/work/py-libp2p/py-libp2p> pytest -n auto --timeout=1200 tests/core pid=2376
py311-core: FAIL code 1 (581.97=setup[27.44]+cmd[554.53] seconds)
evaluation failed :( (582.54 seconds)
Error: Process completed with exit code 1.

seetadev · 2025-11-14T09:49:04Z

@codemaestro64 : Wonderful efforts indeed. Appreciate your contribution.

Wish if you could mark the todos at #691 completed in your PR. We are reviewing the PR in details, once again. It is indeed heading towards final review + merge. Great progress.

On the same note, wish if you could open up a discussion page sharing more details on the implementation steps and test suite.

CCing @pacrob, @Winter-Soren, who are reviewing this PR. Looking forward to their pointers and feedback.

pacrob · 2025-11-18T03:07:12Z

pyproject.toml

+[tool.ruff.per-file-ignores]
+"tests/*.py" = ["F821"]  # undefined name (e.g., pytest fixtures like mocker)
+


I'm not getting an error with this. Is it necessary?

No longer needed. Removed

pacrob · 2025-11-18T22:13:02Z

libp2p/relay/circuit_v2/transport.py

+    async def handle_incoming_connection(
+        self,
+        stream: INetStream,
+        remote_peer_id: ID,


This arg is never used in the function.

My bad. It's been removed

pacrob · 2025-11-19T18:42:11Z

libp2p/relay/circuit_v2/protocol.py

                        voucher=b"",  # We don't use vouchers yet
                        signature=b"",  # We don't use signatures yet


Should these be updated? It looks like we are checking against these values in RelayResourceManager->verify_reservation, but they are always empty strings here.

@pacrob Vouchers haven't been implemented yet. @seetadev I'd be happy to pick that up as soon as you give the word. But I suggest this PR be reviewed and merged as this and the Voucher implementation are of two scopes

@codemaestro64 : Thank you for sharing your feedback on voucher implementation.

Vouchers have been implemented. In #698, @guha-rahul fixed voucher verification and data transfer limits in Circuit Relay v2. We are just merging that PR in a day or so.

Wish to invite @sukhman-sukh, @Winter-Soren, @acul71 and @guha-rahul to also do a peer review of the features added in this PR.

Wish to ensure that we have all the requisite features in circuit relay as discussed in maintainer's meeting.

seetadev · 2025-11-24T20:16:54Z

@codemaestro64 : Wish if you could address the improvements shared by @pacrob. Appreciate your contribution.

Wish if you also could discuss with @Winter-Soren and @sumanjeet0012 and get their pointers while addressing important feedback points by @pacrob.

pacrob

lgtm!

seetadev · 2025-12-05T21:31:20Z

@pacrob : Hi Paul. Thank you so much for your feedback. Appreciate it.

This PR is indeed ready for final review + merged.

@codemaestro64: Wish to recommend you to open a discussion page and share a note for other NAT traversal developers on your implementation details in this PR, test suite. We will like you to follow up this PR with an example demonstrating real use-case of circuit relay and other NAT traversal components in a project.

codemaestro64 force-pushed the trd-enhancements branch 2 times, most recently from 71ea513 to 271cdd6 Compare October 20, 2025 15:48

codemaestro64 marked this pull request as ready for review October 20, 2025 16:59

pacrob reviewed Nov 2, 2025

View reviewed changes

codemaestro64 added 8 commits November 11, 2025 09:50

Implement voucher and signature verification

1077830

improve relay selection. Use round robin selection

a59963f

implement top-N relay selection by score with round-robin picking

824bd20

implement run method

f8abda1

add mocker dependency

a0bb701

add pymock to test depenencies

Implement reservation storage and refresh mechanism

967566a

Store /p2p-circuit/... addresses in the peer metadata to support reco…

5d53ea3

…nnects and discovery

implement DHT-based peer discovery

cc6cd5d

codemaestro64 force-pushed the trd-enhancements branch from 174dc7f to a34f3b4 Compare November 11, 2025 11:52

codemaestro64 added 2 commits November 11, 2025 14:07

add doc

2b1ddba

fix signed_envelope error fix tests fix lint issue

fix lint issues

968dfff

codemaestro64 force-pushed the trd-enhancements branch from 473066e to 968dfff Compare November 11, 2025 13:08

codemaestro64 and others added 2 commits November 11, 2025 14:42

safe fetch stored addrs

80ff293

Merge branch 'main' into trd-enhancements

d4fc15b

seetadev added 2 commits November 12, 2025 03:19

Merge branch 'main' into trd-enhancements

93226c5

Merge branch 'main' into trd-enhancements

1e53e8a

pacrob reviewed Nov 18, 2025

View reviewed changes

remove unused params

ad45a1b

pacrob reviewed Nov 19, 2025

View reviewed changes

Merge branch 'main' into trd-enhancements

f9e7de4

Merge branch 'main' into trd-enhancements

daddf11

pacrob approved these changes Dec 5, 2025

View reviewed changes

Merge branch 'main' into trd-enhancements

a31db10

seetadev merged commit a720fed into libp2p:main Dec 5, 2025
37 of 38 checks passed

		[tool.ruff.per-file-ignores]
		"tests/*.py" = ["F821"] # undefined name (e.g., pytest fixtures like mocker)

		voucher=b"", # We don't use vouchers yet
		signature=b"", # We don't use signatures yet

Conversation

codemaestro64 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was wrong?

Description

TODOs

Uh oh!

seetadev commented Oct 20, 2025

Uh oh!

seetadev commented Oct 27, 2025

Uh oh!

Winter-Soren commented Oct 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seetadev commented Nov 11, 2025

Uh oh!

seetadev commented Nov 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seetadev commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pacrob left a comment

Choose a reason for hiding this comment

Uh oh!

seetadev commented Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codemaestro64 commented Oct 16, 2025 •

edited

Loading

seetadev commented Nov 24, 2025 •

edited

Loading