fix(gossipsub): add instant to make gossipsub work on browser

[shuning-auki]

Description

Related #5620

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[jxs]

Hi, and thanks for this! I'd rather we try to fix this upstream, let's do this if you agree, we submit a fix upstream and give it a window to be merged and released, if it doesn't we address the issue via this PR.
cc @dariusc93

[dariusc93]

Thanks for the PR @shuning-auki!

Hi, and thanks for this! I'd rather we try to fix this upstream, let's do this if you agree, we submit a fix upstream and give it a window to be merged and released, if it doesn't we address the issue via this PR. cc @dariusc93

I agree. It is a simple fix upstream while the PR (per suggestion from the issue) is more of a temporary workaround to get this back working unless we wish to remove futures-ticker altogether if a fix isnt merged upstream.

[mergify]

This pull request has merge conflicts. Could you please resolve them @shuning-auki? 🙏

[dariusc93]

As I think on this, I wonder if we could remove futures-ticker instead. It was introduced in #3973 and from my understanding it was to used as an Interval alternative to wasm-timer Interval. Should be a simple change by using Delay from futures-timer instead (though would still need a little rework of logic)

Thoughts on this @jxs @shuning-auki? It would be one less dependency

[jxs]

As I think on this, I wonder if we could remove futures-ticker instead. It was introduced in #3973 and from my understanding it was to used as an Interval alternative to wasm-timer Interval. Should be a simple change by using Delay from futures-timer instead (though would still need a little rework of logic)

Thoughts on this @jxs @shuning-auki? It would be one less dependency

yeah makes sense to me, thanks for investigating Darius. If anyone wants to ahead and do it, otherwise I can also take a stab at it :)

[jxs]

addressed with #5674