libp2p · kamuik16 · Nov 28, 2024 · Nov 28, 2024
diff --git a/Cargo.toml b/Cargo.toml
@@ -152,6 +152,7 @@ clippy.type_complexity = "allow"
 clippy.unnecessary_wraps = "warn"
 clippy.manual_let_else = "warn"
 clippy.dbg_macro = "warn"
+clippy.wildcard_imports = "warn"
 
 [workspace.metadata.release]
 pre-release-hook = [

diff --git a/clippy.toml b/clippy.toml
@@ -2,3 +2,4 @@ disallowed-methods = [
   { path = "futures::channel::mpsc::unbounded", reason = "does not enforce backpressure" },
 ]
 avoid-breaking-exported-api = false
+allowed-wildcard-imports = ["super"]
diff --git a/core/src/generated/envelope_proto.rs b/core/src/generated/envelope_proto.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::sizeof_len;
 use super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/core/src/generated/peer_record_proto.rs b/core/src/generated/peer_record_proto.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/identity/src/generated/keys_proto.rs b/identity/src/generated/keys_proto.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::*;
 
 #[derive(Debug, PartialEq, Eq, Clone, Copy)]

diff --git a/identity/src/peer_id.rs b/identity/src/peer_id.rs
@@ -189,7 +189,7 @@ impl<'de> Deserialize<'de> for PeerId {
     where
         D: serde::Deserializer<'de>,
     {
-        use serde::de::*;
+        use serde::de::{Error, Unexpected, Visitor};
 
         struct PeerIdVisitor;
 

diff --git a/libp2p/src/builder/phase.rs b/libp2p/src/builder/phase.rs
@@ -14,20 +14,20 @@
 mod tcp;
 mod websocket;
 
-use bandwidth_logging::*;
-use bandwidth_metrics::*;
-use behaviour::*;
-use build::*;
-use dns::*;
+use bandwidth_logging::BandwidthLoggingPhase;
+use bandwidth_metrics::BandwidthMetricsPhase;
+use behaviour::{BehaviourPhase, TryIntoBehaviour};
+use build::BuildPhase;
+use dns::DnsPhase;
 use libp2p_core::{muxing::StreamMuxerBox, Transport};
 use libp2p_identity::Keypair;
-use other_transport::*;
-use provider::*;
-use quic::*;
-use relay::*;
-use swarm::*;
-use tcp::*;
-use websocket::*;
+use other_transport::{OtherTransportPhase, TryIntoTransport};
+use provider::{AsyncStd, NoProviderSpecified, ProviderPhase};
+use quic::QuicPhase;
+use relay::{NoRelayBehaviour, RelayPhase};
+use swarm::SwarmPhase;
+use tcp::TcpPhase;
+use websocket::{WebsocketError, WebsocketPhase};
 
 use super::{
     select_muxer::SelectMuxerUpgrade, select_security::SelectSecurityUpgrade, SwarmBuilder,

diff --git a/misc/quick-protobuf-codec/src/generated/test.rs b/misc/quick-protobuf-codec/src/generated/test.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::sizeof_len;
 use super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/misc/webrtc-utils/src/generated/webrtc/pb.rs b/misc/webrtc-utils/src/generated/webrtc/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/autonat/src/v1/generated/structs.rs b/protocols/autonat/src/v1/generated/structs.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/autonat/src/v2/generated/structs.rs b/protocols/autonat/src/v2/generated/structs.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::*;
 
 #[derive(Debug, PartialEq, Eq, Clone, Copy)]

diff --git a/protocols/dcutr/src/generated/holepunch/pb.rs b/protocols/dcutr/src/generated/holepunch/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/floodsub/src/generated/floodsub/pb.rs b/protocols/floodsub/src/generated/floodsub/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/gossipsub/src/generated/compat/pb.rs b/protocols/gossipsub/src/generated/compat/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::sizeof_len;
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/gossipsub/src/generated/gossipsub/pb.rs b/protocols/gossipsub/src/generated/gossipsub/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/identify/src/generated/structs.rs b/protocols/identify/src/generated/structs.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::sizeof_len;
 use super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/kad/src/behaviour.rs b/protocols/kad/src/behaviour.rs
@@ -50,7 +50,7 @@ use crate::{
     addresses::Addresses,
     bootstrap,
     handler::{Handler, HandlerEvent, HandlerIn, RequestId},
-    jobs::*,
+    jobs::{AddProviderJob, PutRecordJob, JOBS_MAX_NEW_QUERIES, JOBS_MAX_QUERIES},
     kbucket::{self, Distance, KBucketConfig, KBucketsTable, NodeStatus},
     protocol,
     protocol::{ConnectionType, KadPeer, ProtocolConfig},

diff --git a/protocols/kad/src/generated/dht/pb.rs b/protocols/kad/src/generated/dht/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/protocols/kad/src/kbucket/key.rs b/protocols/kad/src/kbucket/key.rs
@@ -29,7 +29,7 @@ use sha2::{
     digest::generic_array::{typenum::U32, GenericArray},
     Digest, Sha256,
 };
-use uint::*;
+use uint::{construct_uint, unroll};
 
 use crate::record;
 

diff --git a/protocols/relay/src/generated/message_v2/pb.rs b/protocols/relay/src/generated/message_v2/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[derive(Debug, PartialEq, Eq, Clone, Copy)]

diff --git a/protocols/rendezvous/src/generated/rendezvous/pb.rs b/protocols/rendezvous/src/generated/rendezvous/pb.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::{sizeof_len, sizeof_varint};
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/transports/noise/src/generated/payload/proto.rs b/transports/noise/src/generated/payload/proto.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::sizeof_len;
 use super::super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/transports/plaintext/src/generated/structs.rs b/transports/plaintext/src/generated/structs.rs
@@ -10,7 +10,7 @@
 
 
 use quick_protobuf::{MessageInfo, MessageRead, MessageWrite, BytesReader, Writer, WriterBackend, Result};
-use quick_protobuf::sizeofs::*;
+use quick_protobuf::sizeofs::sizeof_len;
 use super::*;
 
 #[allow(clippy::derive_partial_eq_without_eq)]

diff --git a/transports/tls/src/certificate.rs b/transports/tls/src/certificate.rs
@@ -407,7 +407,13 @@ impl P2pCertificate<'_> {
     fn signature_scheme(&self) -> Result<rustls::SignatureScheme, webpki::Error> {
         // Certificates MUST use the NamedCurve encoding for elliptic curve parameters.
         // Endpoints MUST abort the connection attempt if it is not used.
-        use oid_registry::*;
+        use oid_registry::{
+            OID_EC_P256, OID_KEY_TYPE_EC_PUBLIC_KEY, OID_NIST_EC_P384, OID_NIST_EC_P521,
+            OID_NIST_HASH_SHA256, OID_NIST_HASH_SHA384, OID_NIST_HASH_SHA512,
+            OID_PKCS1_RSAENCRYPTION, OID_PKCS1_RSASSAPSS, OID_PKCS1_SHA256WITHRSA,
+            OID_PKCS1_SHA384WITHRSA, OID_PKCS1_SHA512WITHRSA, OID_SIG_ECDSA_WITH_SHA256,
+            OID_SIG_ECDSA_WITH_SHA384, OID_SIG_ECDSA_WITH_SHA512, OID_SIG_ED25519, OID_SIG_ED448,
+        };
         use rustls::SignatureScheme::*;
 
         let signature_algorithm = &self.certificate.signature_algorithm;