Skip to content

Conversation

@tesol2y090
Copy link
Contributor

Description

Implement RwStreamSink inlined into the memory-transport implementation

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@tesol2y090 tesol2y090 changed the title Misc/memory transport misc: implement RwStreamSink in memory transport Dec 17, 2024
@tesol2y090 tesol2y090 marked this pull request as ready for review December 17, 2024 10:32
@elenaf9
Copy link
Member

elenaf9 commented Dec 25, 2024

Thanks for the PR @tesol2y090!

While reviewing this PR, I noticed that it doesn't really make sense anymore to remove the rw-stream-sink crate, because it is used by now by more than the two crates mentioned in #4345. So I don't think we need to inline RwStrreamSink in the memory transport anymore.

Sorry for only noticing this now!

@jxs jxs closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants