fix(upnp): panic during a shutdown process#5998
Merged
mergify[bot] merged 3 commits intolibp2p:masterfrom Apr 23, 2025
Merged
Conversation
jxs
previously approved these changes
Apr 22, 2025
Member
jxs
left a comment
There was a problem hiding this comment.
Thanks for this Akihito! LGTM! ❤️
Approvals have been dismissed because the PR was updated after the send-it label was applied.
jxs
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
upnp panics here in case where the gateway state is
Searchingand the task executor is shutting down, since the search_gateway task is terminated and the sender channel has been dropped.Here is an example code that reproduces the issue based on the upnp example, along with the corresponding error message.
Since this case is expected during shutdown, I believe upnp should avoid panicking and continue its operation.
Notes & open questions
Should we add new variant to
GatewayStateandEventfor this?Change checklist