fix(request-response): don't fail requests on DialPeerConditionFalse#6000
Merged
mergify[bot] merged 5 commits intolibp2p:masterfrom Apr 29, 2025
Merged
Conversation
elenaf9
changed the title
DialError::DialPeerConditionFalseDialPeerConditionFalse
MatthiasvB
pushed a commit
to MatthiasvB/rust-libp2p
that referenced
this pull request
May 5, 2025
If a dial fails because of an unmet peer condition, it just means that there is already an ongoing dial. We shouldn't fail the pending outbound requests to the peer in that case. Fixes libp2p#5996. Pull-Request: libp2p#6000.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a dial fails because of an unmet peer condition, it just means that there is already an ongoing dial.
We shouldn't fail the pending outbound requests to the peer in that case.
Fixes #5996.
Notes & open questions
Change checklist