kad: Randomize node count in get_providers_limit test#6008
Closed
GarmashAlex wants to merge 1 commit intolibp2p:masterfrom
Closed
kad: Randomize node count in get_providers_limit test#6008GarmashAlex wants to merge 1 commit intolibp2p:masterfrom
GarmashAlex wants to merge 1 commit intolibp2p:masterfrom
Conversation
Member
|
The test only uses 3 nodes, it doesn't make any sense to create more if they don't participate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves the TODO in the get_providers_limit test by replacing the fixed number
of nodes (12) with a randomized value between 3 and 20. This makes the test more
robust by testing with different network sizes on each run.
Also fixes a type inference issue with the const generic parameter N by explicitly
specifying the type when passing the prop function to QuickCheck.
Change checklist