Skip to content

Conversation

elenaf9
Copy link
Member

@elenaf9 elenaf9 commented Jun 25, 2025

Description

#6015 made the timeout for outbound substreams in kademlia configurable by introducing a outbound_substreams_timeout config option.
There is currently an open PR #6009 that plans to also apply that timeout to inbound substream, in which case we probably want toe rename the config option to substreams_timeout (without the prefix).
Because we plan to release soon and might not get #6009 in in-time, I propose that we already do the renaming now, to avoid breaking the API again with the next release.

Notes & open questions

I directly changed the initial changelog entry of #6009 to avoid confusion. Is that okay or should a add a separate changelog entry for the renaming?

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elena! LGTM left just one comment

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jxs jxs added the send-it label Jun 26, 2025
@mergify mergify bot merged commit f4e5a8d into libp2p:master Jun 26, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants