Skip to content

fix(identify): check actual port reuse instead of original intent #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(identify): check actual port reuse instead of original intent #6096

wants to merge 1 commit into from

Conversation

ErakhtinB
Copy link

When PortUse::Reuse fails and falls back to ephemeral ports, detect this by comparing observed ports with listening ports rather than tracking the original PortUse intent.

Fixes #5820

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@ErakhtinB
fix(identify): check actual port reuse instead of original intent
11fa89f 
When PortUse::Reuse fails and falls back to ephemeral ports,
detect this by comparing observed ports with listening ports
rather than tracking the original PortUse intent.

Fixes libp2p#5820
@ErakhtinB ErakhtinB mentioned this pull request Jul 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address translation doesn't work correctly with non-reused ephemeral ports
1 participant
@ErakhtinB