Skip to content

Conversation

RandyMcMillan
Copy link

@RandyMcMillan RandyMcMillan commented Aug 9, 2025

let devs capture local_peer_id manually - don't force an info! log

@RandyMcMillan RandyMcMillan force-pushed the 1929/909289/732520/6433611ac/e29dad64d-swarm/src/lib.rs branch from d038b79 to 2c6d578 Compare August 9, 2025 14:56
@RandyMcMillan RandyMcMillan changed the title swarm/src/lib.rs:tracing::debug!(%local_peer_id) fix: swarm/src/lib.rs:tracing::debug!(%local_peer_id) Aug 9, 2025
@jxs jxs added the typo-fix label Aug 11, 2025
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, since this is a public function I agree the logging kinda becomes redundant.
Can you add an entry to CHANGELOG.md and check if Cargo.toml needs updating?
Thanks

@jxs jxs removed the typo-fix label Aug 19, 2025
RandyMcMillan added a commit to RandyMcMillan/rust-libp2p that referenced this pull request Aug 19, 2025
RandyMcMillan added a commit to RandyMcMillan/rust-libp2p that referenced this pull request Aug 19, 2025
@RandyMcMillan RandyMcMillan force-pushed the 1929/909289/732520/6433611ac/e29dad64d-swarm/src/lib.rs branch from 2c6d578 to 3d9f4b1 Compare August 19, 2025 16:43
@RandyMcMillan RandyMcMillan force-pushed the 1929/909289/732520/6433611ac/e29dad64d-swarm/src/lib.rs branch from 3d9f4b1 to 263fa78 Compare August 19, 2025 16:45
@@ -102,7 +102,7 @@ libp2p-rendezvous = { version = "0.17.0", path = "protocols/rendezvous" }
libp2p-request-response = { version = "0.29.0", path = "protocols/request-response" }
libp2p-server = { version = "0.12.7", path = "misc/server" }
libp2p-stream = { version = "0.4.0-alpha", path = "protocols/stream" }
libp2p-swarm = { version = "0.47.0", path = "swarm" }
libp2p-swarm = { version = "0.47.1", path = "swarm" }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump libp2p-swarm patch version

@@ -1,3 +1,8 @@
## 0.47.1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add pr to swarm/CHANGELOG.md patch version

@@ -3,7 +3,7 @@ name = "libp2p-swarm"
edition.workspace = true
rust-version = { workspace = true }
description = "The libp2p swarm"
version = "0.47.0"
version = "0.47.1"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch version

@@ -353,7 +353,7 @@ where
local_peer_id: PeerId,
config: Config,
) -> Self {
tracing::info!(%local_peer_id);
tracing::debug!(%local_peer_id);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual change

@RandyMcMillan
Copy link
Author

@RandyMcMillan RandyMcMillan requested a review from jxs August 19, 2025 16:53
@RandyMcMillan
Copy link
Author

Hi, since this is a public function I agree the logging kinda becomes redundant. Can you add an entry to CHANGELOG.md and check if Cargo.toml needs updating? Thanks

thanks for the feed back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants