-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: swarm/src/lib.rs:tracing::debug!(%local_peer_id) #6123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: swarm/src/lib.rs:tracing::debug!(%local_peer_id) #6123
Conversation
d038b79
to
2c6d578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, since this is a public function I agree the logging kinda becomes redundant.
Can you add an entry to CHANGELOG.md and check if Cargo.toml
needs updating?
Thanks
2c6d578
to
3d9f4b1
Compare
3d9f4b1
to
263fa78
Compare
@@ -102,7 +102,7 @@ libp2p-rendezvous = { version = "0.17.0", path = "protocols/rendezvous" } | |||
libp2p-request-response = { version = "0.29.0", path = "protocols/request-response" } | |||
libp2p-server = { version = "0.12.7", path = "misc/server" } | |||
libp2p-stream = { version = "0.4.0-alpha", path = "protocols/stream" } | |||
libp2p-swarm = { version = "0.47.0", path = "swarm" } | |||
libp2p-swarm = { version = "0.47.1", path = "swarm" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump libp2p-swarm patch version
@@ -1,3 +1,8 @@ | |||
## 0.47.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add pr to swarm/CHANGELOG.md patch version
@@ -3,7 +3,7 @@ name = "libp2p-swarm" | |||
edition.workspace = true | |||
rust-version = { workspace = true } | |||
description = "The libp2p swarm" | |||
version = "0.47.0" | |||
version = "0.47.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch version
@@ -353,7 +353,7 @@ where | |||
local_peer_id: PeerId, | |||
config: Config, | |||
) -> Self { | |||
tracing::info!(%local_peer_id); | |||
tracing::debug!(%local_peer_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual change
thanks for the feed back! |
let devs capture local_peer_id manually - don't force an info! log