-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(gossipsub): Changed unsubscribe_backoff to expect Duration #6124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gossipsub): Changed unsubscribe_backoff to expect Duration #6124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me.
Although you have linked an issue, can you please add a description and motivation for this PR.
This PR is what is primarily linked to the squashed commit and is what users will lookup in the history. All our PRs should have an accurate description and motivation.
Also, we need to modify the CHANGELOG in gossipsub, which is partially why CI is failing. Also this modifies the user-facing API and will need a version update to include it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will need a version bump to handle the API change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need a version bump to handle the API change.
v0.50.0
is not released yet, so no version bump is needed. Only the changelog entry needs to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Gossipsub config back-off takes a duration as a number of seconds instead of
std::time::Duration
, this PR fixes that.Fixes #6120
Notes & open questions
Allows using sub second and more specific unsubscribe_backoff times
Change checklist